Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 3561012: More refactoring of class Compiler's interface. (Closed)

Created:
10 years, 2 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

More refactoring of class Compiler's interface. Change more functions used by the Compiler class to have a uniform interface: they get passed as argument an input/output pointer to a CompilationInfo that they mutate if they succeed, and they return a flag telling whether they succeeded. Also, remove some unnecessary timers. Committed: http://code.google.com/p/v8/source/detail?r=5583

Patch Set 1 #

Patch Set 2 : Reindent some code, change some copyright dates. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+336 lines, -294 lines) Patch
M src/arm/codegen-arm.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/arm/codegen-arm.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/ast.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/codegen.cc View 1 3 chunks +13 lines, -9 lines 0 comments Download
M src/compiler.h View 1 9 chunks +35 lines, -23 lines 1 comment Download
M src/compiler.cc View 8 chunks +142 lines, -169 lines 0 comments Download
M src/data-flow.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/data-flow.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M src/full-codegen.h View 1 chunk +1 line, -1 line 0 comments Download
M src/full-codegen.cc View 1 4 chunks +16 lines, -7 lines 0 comments Download
M src/ia32/codegen-ia32.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/ia32/codegen-ia32.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/liveedit.cc View 1 chunk +9 lines, -11 lines 0 comments Download
M src/objects.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M src/objects.cc View 1 2 chunks +8 lines, -1 line 0 comments Download
M src/rewriter.h View 2 chunks +18 lines, -13 lines 0 comments Download
M src/rewriter.cc View 1 3 chunks +24 lines, -16 lines 0 comments Download
M src/scopes.h View 1 3 chunks +9 lines, -1 line 0 comments Download
M src/scopes.cc View 1 3 chunks +24 lines, -2 lines 0 comments Download
M src/v8-counters.h View 2 chunks +2 lines, -9 lines 0 comments Download
M src/x64/codegen-x64.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/x64/codegen-x64.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
10 years, 2 months ago (2010-10-04 13:37:08 UTC) #1
fschneider
10 years, 2 months ago (2010-10-04 14:24:54 UTC) #2
LGTM.

http://codereview.chromium.org/3561012/diff/2001/3006
File src/compiler.h (right):

http://codereview.chromium.org/3561012/diff/2001/3006#newcode85
src/compiler.h:85: ASSERT(scope_ == NULL);
Maybe make the things SetOncePointer if they are initialized once?

Powered by Google App Engine
This is Rietveld 408576698