Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 3557010: Reapply r5603 with additional fix: use OS::StrNCpy instead of posix strncpy. (Closed)

Created:
10 years, 2 months ago by Florian Loitsch
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Implement fast case for strtod. Reapply r5603 with additional fix: use OS::StrNCpy instead of posix strncpy. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=5605

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -4 lines) Patch
M src/conversions.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/strtod.h View 1 chunk +1 line, -1 line 0 comments Download
M src/strtod.cc View 2 chunks +98 lines, -1 line 0 comments Download
M test/cctest/SConscript View 1 chunk +1 line, -0 lines 0 comments Download
A test/cctest/test-strtod.cc View 1 chunk +155 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Loitsch
10 years, 2 months ago (2010-10-07 12:46:56 UTC) #1
Bill Hesse
LGTM.
10 years, 2 months ago (2010-10-07 12:51:08 UTC) #2
William Hesse
10 years, 2 months ago (2010-10-07 12:51:35 UTC) #3
LGTM too.

Powered by Google App Engine
This is Rietveld 408576698