Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 3557007: Add assert to make sure that function refers to compiled code in handles.cc (Closed)

Created:
10 years, 2 months ago by mnaganov (inactive)
Modified:
9 years, 7 months ago
Reviewers:
Rico
CC:
v8-dev
Visibility:
Public.

Description

Previously, there was a bug there, fixed in r5581. But having an assert still makes sense. Also, add functions registration to CPU profiler in case when closure code wasn't compiled yet. Committed: http://code.google.com/p/v8/source/detail?r=5582

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/compiler.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/handles.cc View 2 chunks +2 lines, -0 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
mnaganov (inactive)
10 years, 2 months ago (2010-10-04 12:21:45 UTC) #1
Rico
LGTM http://codereview.chromium.org/3557007/diff/1/3 File src/handles.cc (right): http://codereview.chromium.org/3557007/diff/1/3#newcode813 src/handles.cc:813: PROFILE(FunctionCreateEvent(*function)); Maybee assert that the code on the ...
10 years, 2 months ago (2010-10-04 12:27:31 UTC) #2
mnaganov (inactive)
10 years, 2 months ago (2010-10-04 12:37:58 UTC) #3
http://codereview.chromium.org/3557007/diff/1/3
File src/handles.cc (right):

http://codereview.chromium.org/3557007/diff/1/3#newcode813
src/handles.cc:813: PROFILE(FunctionCreateEvent(*function));
On 2010/10/04 12:27:31, Rico wrote:
> Maybee assert that the code on the function object is not the compile stub
> (since this would have caught the old bug) and the same above in CompileLazy

OK, added!

Powered by Google App Engine
This is Rietveld 408576698