Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Unified Diff: frontend/client/src/autotest/afe/HostSelector.java

Issue 3554003: Merge remote branch 'cros/upstream' into tempbranch3 (Closed) Base URL: http://git.chromium.org/git/autotest.git
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « frontend/client/src/autotest/afe/HostListView.java ('k') | frontend/client/src/autotest/afe/IButton.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frontend/client/src/autotest/afe/HostSelector.java
diff --git a/frontend/client/src/autotest/afe/HostSelector.java b/frontend/client/src/autotest/afe/HostSelector.java
index 22951b22b1db26df2075fd16703cd571bf47a558..b4c98380ae6fce15d81075ddc0ea77deac122dde 100644
--- a/frontend/client/src/autotest/afe/HostSelector.java
+++ b/frontend/client/src/autotest/afe/HostSelector.java
@@ -2,12 +2,12 @@ package autotest.afe;
import autotest.common.Utils;
import autotest.common.table.ArrayDataSource;
-import autotest.common.table.SelectionManager;
-import autotest.common.table.TableDecorator;
import autotest.common.table.DataSource.DefaultDataCallback;
import autotest.common.table.DataSource.Query;
import autotest.common.table.DynamicTable.DynamicTableListener;
+import autotest.common.table.SelectionManager;
import autotest.common.table.SelectionManager.SelectionListener;
+import autotest.common.table.TableDecorator;
import autotest.common.ui.NotifyManager;
import autotest.common.ui.SimplifiedList;
@@ -126,9 +126,9 @@ public class HostSelector implements ClickHandler {
if (isMetaEntry(row) || isOneTimeHost(row)) {
deselectRow(row);
selectionRefresh();
- }
- else
+ } else {
availableSelection.deselectObject(row);
+ }
}
public void onTableRefreshed() {}
@@ -269,8 +269,8 @@ public class HostSelector implements ClickHandler {
private void populateLabels(SimplifiedList list) {
String[] labelNames = AfeUtils.getLabelStrings();
- for(int i = 0; i < labelNames.length; i++) {
- list.addItem(labelNames[i], "");
+ for (String labelName : labelNames) {
+ list.addItem(labelName, "");
}
}
« no previous file with comments | « frontend/client/src/autotest/afe/HostListView.java ('k') | frontend/client/src/autotest/afe/IButton.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698