Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: frontend/client/src/autotest/afe/AfeClient.java

Issue 3554003: Merge remote branch 'cros/upstream' into tempbranch3 (Closed) Base URL: http://git.chromium.org/git/autotest.git
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/tests/xmtest/xmtest.py ('k') | frontend/client/src/autotest/afe/AfeUtils.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frontend/client/src/autotest/afe/AfeClient.java
diff --git a/frontend/client/src/autotest/afe/AfeClient.java b/frontend/client/src/autotest/afe/AfeClient.java
index 3546708155d58c9fd8ac1ecf999e5cc8a49fc35f..bea64843ddbcfbfec2e8f51d842b9f526eb6a4e0 100644
--- a/frontend/client/src/autotest/afe/AfeClient.java
+++ b/frontend/client/src/autotest/afe/AfeClient.java
@@ -1,12 +1,13 @@
package autotest.afe;
-import autotest.afe.CreateJobView.JobCreateListener;
import autotest.afe.HostDetailView.HostDetailListener;
import autotest.afe.HostListView.HostListListener;
import autotest.afe.JobDetailView.JobDetailListener;
import autotest.afe.JobListView.JobSelectListener;
import autotest.afe.RecurringView.RecurringSelectListener;
import autotest.afe.UserPreferencesView.UserPreferencesListener;
+import autotest.afe.create.CreateJobViewPresenter.JobCreateListener;
+import autotest.afe.create.CreateJobViewTab;
import autotest.common.CustomHistory;
import autotest.common.JsonRpcProxy;
import autotest.common.SiteCommonClassFactory;
@@ -24,7 +25,7 @@ public class AfeClient implements EntryPoint {
private JobListView jobList;
private JobDetailView jobDetail;
private RecurringView recurringView;
- private CreateJobView createJob;
+ private CreateJobViewTab createJob;
private HostListView hostListView;
private HostDetailView hostDetailView;
private UserPreferencesView userPreferencesView;
@@ -37,7 +38,7 @@ public class AfeClient implements EntryPoint {
public void onModuleLoad() {
JsonRpcProxy.setDefaultBaseUrl(JsonRpcProxy.AFE_BASE_URL);
NotifyManager.getInstance().initialize();
-
+
// initialize static data, and don't show main UI until that's done
StaticDataRepository.getRepository().refresh(
new StaticDataRepository.FinishedCallback() {
@@ -46,13 +47,13 @@ public class AfeClient implements EntryPoint {
}
});
}
-
+
private JobCreateListener jobCreateListener = new JobCreateListener() {
public void onJobCreated(int jobId) {
showJob(jobId);
}
};
-
+
protected void finishLoading() {
SiteCommonClassFactory.globalInitialize();
@@ -65,59 +66,59 @@ public class AfeClient implements EntryPoint {
public void onHostSelected(String hostname) {
showHost(hostname);
}
-
+
public void onCloneJob(JSONValue cloneInfo) {
createJob.ensureInitialized();
createJob.cloneJob(cloneInfo);
mainTabPanel.selectTabView(createJob);
}
-
+
public void onCreateRecurringJob(int jobId) {
recurringView.ensureInitialized();
recurringView.createRecurringJob(jobId);
mainTabPanel.selectTabView(recurringView);
}
});
-
- recurringView = new RecurringView(new RecurringSelectListener() {
+
+ recurringView = new RecurringView(new RecurringSelectListener() {
public void onRecurringSelected(int jobId) {
showJob(jobId);
}
});
-
+
createJob = AfeUtils.factory.getCreateJobView(jobCreateListener);
-
+
hostListView = new HostListView(new HostListListener() {
public void onHostSelected(String hostname) {
showHost(hostname);
}
}, jobCreateListener);
-
+
hostDetailView = new HostDetailView(new HostDetailListener() {
public void onJobSelected(int jobId) {
showJob(jobId);
}
}, jobCreateListener);
-
+
userPreferencesView = new UserPreferencesView(new UserPreferencesListener() {
public void onPreferencesChanged() {
createJob.onPreferencesChanged();
}
});
-
- TabView[] tabViews = new TabView[] {jobList, jobDetail, recurringView, createJob,
+
+ TabView[] tabViews = new TabView[] {jobList, jobDetail, recurringView, createJob,
hostListView, hostDetailView, userPreferencesView};
- for(int i = 0; i < tabViews.length; i++) {
- mainTabPanel.addTabView(tabViews[i]);
+ for (TabView tabView : tabViews) {
+ mainTabPanel.addTabView(tabView);
}
-
+
final RootPanel tabsRoot = RootPanel.get("tabs");
tabsRoot.add(mainTabPanel);
CustomHistory.processInitialToken();
mainTabPanel.initialize();
tabsRoot.setStyleName("");
}
-
+
protected void showJob(int jobId) {
jobDetail.ensureInitialized();
jobDetail.updateObjectId(Integer.toString(jobId));
« no previous file with comments | « client/tests/xmtest/xmtest.py ('k') | frontend/client/src/autotest/afe/AfeUtils.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698