Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 3554002: Initial auto update engine test harness commit. (Closed)

Created:
10 years, 2 months ago by sosa
Modified:
9 years, 6 months ago
Reviewers:
petkov, rtc, adlr
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Initial auto update engine test harness. This harness has support for test on vm machines. It takes a base image and target image path, creates an update-enabled vm image from the base image and performs updates using cros_run_vm_update (vm wrapper around image_to_live). It uses --snapshot for updating vm's and keeps them on (like a real machine would) so that the VM image is clean on the next test. The current check in has two test cases -- updates without clobbering the stateful partition and updates with clobbering the stateful partition. Change-Id: I5406eadb39fa36601d17f8dd15625bd6a8b38c15 BUG=6911 TEST=Ran through tests. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=bccc7c1

Patch Set 1 #

Patch Set 2 : Fix ws #

Total comments: 8

Patch Set 3 : Fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -0 lines) Patch
A bin/cros_au_test_harness View 1 chunk +1 line, -0 lines 0 comments Download
A bin/cros_au_test_harness.py View 1 2 1 chunk +170 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sosa
petkov - for use of cros_run_vm_update (though free to do all) adlr/rtc - for actual ...
10 years, 2 months ago (2010-09-29 01:46:56 UTC) #1
petkov
LGTM http://codereview.chromium.org/3554002/diff/2001/3002 File bin/cros_au_test_harness.py (right): http://codereview.chromium.org/3554002/diff/2001/3002#newcode20 bin/cros_au_test_harness.py:20: global base_image_path any way you can avoid these ...
10 years, 2 months ago (2010-09-29 20:49:53 UTC) #2
sosa
10 years, 2 months ago (2010-09-30 22:05:05 UTC) #3
Re-tested and pushing.

http://codereview.chromium.org/3554002/diff/2001/3002
File bin/cros_au_test_harness.py (right):

http://codereview.chromium.org/3554002/diff/2001/3002#newcode20
bin/cros_au_test_harness.py:20: global base_image_path
On 2010/09/29 20:49:54, petkov wrote:
> any way you can avoid these globals?
> 
I couldn't find a way :(.  It's very hard to pass items to unit tests since you
don't have control over their instances.

http://codereview.chromium.org/3554002/diff/2001/3002#newcode37
bin/cros_au_test_harness.py:37: old:  Don't modify stateful partition.  Just
update normally.
On 2010/09/29 20:49:54, petkov wrote:
> 'old', 'clean'
> 

Done.

http://codereview.chromium.org/3554002/diff/2001/3002#newcode50
bin/cros_au_test_harness.py:50: #self.VerifyImage()
On 2010/09/29 20:49:54, petkov wrote:
> why is this commented out?
> 
> 

Done.

http://codereview.chromium.org/3554002/diff/2001/3002#newcode144
bin/cros_au_test_harness.py:144: '--test_case=%s' % 'suite_Smoke'
On 2010/09/29 20:49:54, petkov wrote:
> make suiteSmoke a global constant?
> 

Done.

Powered by Google App Engine
This is Rietveld 408576698