Issue 355041: Made iteration of global handles more efficient on scavenges.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 355041: Made iteration of global handles more efficient on scavenges. (Closed)

Created:
11 years, 1 month ago by Christian Plesner Hansen

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Made iteration of global handles more efficient on scavenges.

Patch Set 1 #

Total comments: 2

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -25 lines)			Patch
M	src/global-handles.h	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	src/global-handles.cc	View	2 chunks	+10 lines, -1 line	2 comments	Download
M	src/globals.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/heap.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/heap.cc	View	6 chunks	+12 lines, -11 lines	0 comments	Download
M	src/heap-profiler.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/mark-compact.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/serialize.cc	View	6 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/355041/diff/1/2 File src/global-handles.cc (right): http://codereview.chromium.org/355041/diff/1/2#newcode394 Line 394: // Traversal of global handles marked as ...

11 years, 1 month ago (2009-11-05 15:06:19 UTC) #1

Christian Plesner Hansen

11 years, 1 month ago (2009-11-05 15:11:03 UTC) #2

http://codereview.chromium.org/355041/diff/1/2
File src/global-handles.cc (right):

http://codereview.chromium.org/355041/diff/1/2#newcode394
Line 394: // Traversal of global handles marked as NORMAL or NEAR_DEATH.
Fixed

Expand Messages | Collapse Messages