Issue 355037: Coverity: Fix leaking UCharsetDetector in ftp code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 355037: Coverity: Fix leaking UCharsetDetector in ftp code. (Closed)

Created:
11 years, 1 month ago by mattm

Modified:
9 years, 7 months ago

Reviewers:
wtc, jungshik at Google, Paweł Hajdan Jr.

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Coverity: Fix leaking UCharsetDetector in ftp code. CID=7193 BUG=none TEST=using the additional test data, tools/valgrind/chrome_tests.sh -t net --gtest_filter="FtpDirectoryListingBufferTest.*" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31099

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+62 lines, -0 lines)			Patch
A	net/data/ftp/dir-listing-ls-1-utf8	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A	net/data/ftp/dir-listing-ls-1-utf8.expected	View	1 chunk	+53 lines, -0 lines	0 comments	Download
M	net/ftp/ftp_directory_listing_buffer.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/ftp/ftp_directory_listing_buffer_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/glue/ftp_directory_listing_response_delegate.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mattm

I tried adding a more interesting test (shift-jis encoding the source data file, but the ...

11 years, 1 month ago (2009-11-05 01:53:40 UTC) #1

wtc

LGTM. Thanks! Is the new test case based on a real FTP directory listing? The ...

11 years, 1 month ago (2009-11-05 14:46:48 UTC) #3

mattm

11 years, 1 month ago (2009-11-05 17:02:18 UTC) #4

On 2009/11/05 14:46:48, wtc wrote:
> LGTM.  Thanks!
> 
> Is the new test case based on a real FTP
> directory listing?  The Japanese looks good :-)

It's just a modified version of the existing dir-listing-ls-1 test data.

Expand Messages | Collapse Messages