Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 355031: linux: let harfbuzz be pulled in by gyp naturally (Closed)

Created:
11 years, 1 month ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
tony, agl, sgk
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

linux: let harfbuzz be pulled in by gyp naturally Skia correctly depends on Harfbuzz so we don't need to depend on it from the top-level gyp file. TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=31033

Patch Set 1 #

Patch Set 2 : patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Martin
11 years, 1 month ago (2009-11-04 22:38:10 UTC) #1
Evan Martin
11 years, 1 month ago (2009-11-04 22:59:51 UTC) #2
agl
LGTM
11 years, 1 month ago (2009-11-04 23:00:32 UTC) #3
sgk
11 years, 1 month ago (2009-11-04 23:31:19 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698