Making the interactive ui tests run out of process

Making the interactive ui tests run out of process to avoid running
into problems when running several browser tests in the same process.
Turning previously failing tests on.

BUG=26540
TEST=Run the interactive UI tests on Windows and Linux.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30879

[Paweł Hajdan Jr., 2009-11-03 20:01:38]

Drive-by. Great to see this patch!

http://codereview.chromium.org/355014/diff/1/3
File chrome/test/interactive_ui/interactive_ui_tests.gypi (right):

http://codereview.chromium.org/355014/diff/1/3#newcode28
Line 28: # TODO(phajdan.jr): Only temporary, to make transition easier.
You may want to remove this TODO. It seems that this binary should be allowed to
use IN_PROC_BROWSER_TEST as it now uses the correct launcher.

http://codereview.chromium.org/355014/diff/1/3#newcode44
Line 44: # TODO(jcampan): we should use in_proc_test_runner on Windows.
Just curious why? Out of process runner is more robust when tests crash etc...

[rafaelw, 2009-11-03 20:04:57]

lgtm

[jcampan, 2009-11-03 20:23:15]

http://codereview.chromium.org/355014/diff/1/3
File chrome/test/interactive_ui/interactive_ui_tests.gypi (right):

http://codereview.chromium.org/355014/diff/1/3#newcode28
Line 28: # TODO(phajdan.jr): Only temporary, to make transition easier.
On 2009/11/03 20:01:38, Paweł Hajdan Jr. wrote:
> You may want to remove this TODO. It seems that this binary should be allowed
to
> use IN_PROC_BROWSER_TEST as it now uses the correct launcher.

Done.

http://codereview.chromium.org/355014/diff/1/3#newcode44
Line 44: # TODO(jcampan): we should use in_proc_test_runner on Windows.
On 2009/11/03 20:01:38, Paweł Hajdan Jr. wrote:
> Just curious why? Out of process runner is more robust when tests crash etc...
I guess it's easier to debug when it runs in one process.
In the sense that you do not have to know about adding the --child flag. I guess
this is a small advantage though.

[Paweł Hajdan Jr., 2009-11-03 20:25:51]

LGTM

On 2009/11/03 20:23:15, jcampan wrote:
> > You may want to remove this TODO. It seems that this binary should be
allowed
> to
> > use IN_PROC_BROWSER_TEST as it now uses the correct launcher.
> 
> Done.

Thanks.

> http://codereview.chromium.org/355014/diff/1/3#newcode44
> Line 44: # TODO(jcampan): we should use in_proc_test_runner on Windows.
> On 2009/11/03 20:01:38, Paweł Hajdan Jr. wrote:
> > Just curious why? Out of process runner is more robust when tests crash
etc...
> I guess it's easier to debug when it runs in one process.
> In the sense that you do not have to know about adding the --child flag. I
guess
> this is a small advantage though.

OK, indeed it's easier to debug single process.