[Mac] Prefs under the hood work:...

[Mac] Prefs under the hood work:
- Make all the controls/labels wrap to the width they get.
- Make the content vertically shift as it is made to fit its strings.
- Add more spacing for the sections as listed in bugs.
- Consistent indents for the sections/subsections.
- Update the code to use constant naming (was was "under the hood" and some was "advanced" (just so it is clear they are talking about one thing, and not two).
- DEPS roll for GTM to pick up support for NSPathControl.

TEST=Under the hood content should fit in all languages.
BUG=20538
BUG=25595
BUG=25597
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30825

[Mark Mentovai, 2009-11-03 17:35:44]

LG

http://codereview.chromium.org/355011/diff/2001/2003
File chrome/browser/cocoa/preferences_window_controller.mm (right):

http://codereview.chromium.org/355011/diff/2001/2003#newcode246
Line 246: views = [views sortedArrayUsingFunction:CompareFrameY context:NULL];
Rather than assigning the same crap into the same variable, why not just do:

NSArray* views = [[view subviews] sortedArrayUsingFunction:...]

I think that's preferable to overwriting a variable with something that depends
on the variable itself.

http://codereview.chromium.org/355011/diff/2001/2003#newcode256
Line 256: // The Download Location controls go in a row with the button aligned
to the
blank before?

http://codereview.chromium.org/355011/diff/2001/2003#newcode447
Line 447: // Now that Under the Hood is the right wide, spin through auto sizing
things
hahaha

Now that Under the Hood is the right width, auto-size to the new width to get
the final height.

I think that's what your comment means, it's kind of nonsense now (and not just
because of "teh.")