Issue 355007: Linux: Initialize |restored_bounds_| so new windows always have a proper size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 355007: Linux: Initialize |restored_bounds_| so new windows always have a proper size. (Closed)

Created:
11 years, 1 month ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
Mike Mammarella

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Linux: Initialize |restored_bounds_| so new windows always have a proper size. BUG=none TEST=Resize window to 400x300, hold down ctrl+N, new windows should all be the same size. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30855

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/gtk/browser_window_gtk.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mike Mammarella

http://codereview.chromium.org/355007/diff/1/2 File chrome/browser/gtk/browser_window_gtk.cc (right): http://codereview.chromium.org/355007/diff/1/2#newcode1774 Line 1774: if (!IsFullscreen() && !IsMaximized()) What happens if the ...

11 years, 1 month ago (2009-11-03 19:28:30 UTC) #2

Lei Zhang

On 2009/11/03 19:28:30, Mike Mammarella wrote: > http://codereview.chromium.org/355007/diff/1/2 > File chrome/browser/gtk/browser_window_gtk.cc (right): > > http://codereview.chromium.org/355007/diff/1/2#newcode1774 ...

11 years, 1 month ago (2009-11-03 20:02:18 UTC) #3

Mike Mammarella

11 years, 1 month ago (2009-11-03 20:08:33 UTC) #4

On 2009/11/03 20:02:18, Lei Zhang wrote:
> It turns out that can't happen, since we don't actually maximize until we call
> Show(), and I don't think you can start off in full screen mode.

OK, LGTM then.

Expand Messages | Collapse Messages