Issue 355006: Fix memory problems....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 355006: Fix memory problems.... (Closed)

Created:
11 years, 1 month ago by John Grabowski

Modified:
9 years, 6 months ago

Reviewers:
stuartmorgan

CC:
chromium-reviews_googlegroups.com, not_the_right_glider, ben+cc_chromium.org, John Grabowski, Timur Iskhodzhanov, dank, stuartmorgan, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix memory problems. Remove some dead code. Remove valgrind suppression which suppressed this error. BUG=http://crbug.com/26489 TEST=Mac valgrind bot stays green for ui_test BrowserEncodingTest.TestEncodingAliasMapping Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30793

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -13 lines)			Patch
	M	chrome/browser/cocoa/bookmark_bar_controller.mm	View		2 chunks	+6 lines, -6 lines	0 comments	Download
	M	tools/valgrind/memcheck/suppressions_mac.txt	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages