Issue 355004: More nits discovered by the NaCl builds higher warning level.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 355004: More nits discovered by the NaCl builds higher warning level. (Closed)

Created:
11 years, 1 month ago by sehr (please use chromium)

Modified:
9 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

One more nit discovered by the NaCl build's higher warning level. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30785

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	third_party/npapi/bindings/npapi.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sehr (please use chromium)

One more comma ending an enumeration list, which fails with the -pedantic warning level NaCl ...

11 years, 1 month ago (2009-11-02 23:31:40 UTC) #1

jam

11 years, 1 month ago (2009-11-03 00:03:55 UTC) #2

lgtm

It would probably be good to either send a patch to the Mozilla folks, or open a
bug in their bugtracker, to update their file which is the official header. 
Otherwise future merges might break you.

Expand Messages | Collapse Messages