Issue 3550020: AU: support for generating new style full updates.

Issue 3550020: AU: support for generating new style full updates. (Closed)

Created:
10 years, 2 months ago by adlr

Modified:
9 years ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, petkov, adlr

Base URL:
ssh://git@chromiumos-git/update_engine.git

Visibility:
Public.

Description

AU: support for generating new style full updates. New style full updates are full updates that use the delta upload file format. A full update consists of sequential operations to write the full kernel/rootfs in chunks (currently 128KiB). Because these full updates use the new file format, they get benefits over the old type of full update: - support for embedded signatures - (eventual) support for resuming installation across reboot - help reduce code needed in the updater client software BUG=7248 TEST=generated/applied full update on host; unittests Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=27f7d37

Patch Set 1 #

Total comments: 8

Patch Set 2 : fixes for review #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+195 lines, -17 lines)			Patch
M	delta_diff_generator.h	View	1	1 chunk	+15 lines, -0 lines	0 comments	Download
M	delta_diff_generator.cc	View	1	6 chunks	+104 lines, -9 lines	0 comments	Download
M	delta_performer_unittest.cc	View		3 chunks	+66 lines, -1 line	0 comments	Download
M	generate_delta_main.cc	View		1 chunk	+10 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

petkov

LGTM. Nice! http://codereview.chromium.org/3550020/diff/1/2 File delta_diff_generator.cc (right): http://codereview.chromium.org/3550020/diff/1/2#newcode1132 delta_diff_generator.cc:1132: remove empty line http://codereview.chromium.org/3550020/diff/1/2#newcode1182 delta_diff_generator.cc:1182: const vector<char>& ...

10 years, 2 months ago (2010-10-07 04:18:18 UTC) #2

adlr

10 years, 2 months ago (2010-10-07 18:27:11 UTC) #3

fixed and pushed. thanks

http://codereview.chromium.org/3550020/diff/1/2
File delta_diff_generator.cc (right):

http://codereview.chromium.org/3550020/diff/1/2#newcode1132
delta_diff_generator.cc:1132: 
On 2010/10/07 04:18:18, petkov wrote:
> remove empty line
> 

Done.

http://codereview.chromium.org/3550020/diff/1/2#newcode1182
delta_diff_generator.cc:1182: const vector<char>& use_buf = (compress ?
buf_compressed : buf);
On 2010/10/07 04:18:18, petkov wrote:
> no need for () on the RHS?
> 

Done.

http://codereview.chromium.org/3550020/diff/1/2#newcode1301
delta_diff_generator.cc:1301: 128 * 1024,
On 2010/10/07 04:18:18, petkov wrote:
> Make this a kConst?
> 

Done.

http://codereview.chromium.org/3550020/diff/1/3
File delta_diff_generator.h (right):

http://codereview.chromium.org/3550020/diff/1/3#newcode196
delta_diff_generator.h:196: static bool ReadFullUpdateFromDisk(
On 2010/10/07 04:18:18, petkov wrote:
> Add a doc string.
> 

Done.

Expand Messages | Collapse Messages