Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 355002: Add a confirmation dialog confirming the completion of uninstallation for Chr... (Closed)

Created:
11 years, 1 month ago by robertshield
Modified:
9 years, 6 months ago
Reviewers:
kuchhal, amit
CC:
chromium-reviews_googlegroups.com, kuchhal
Visibility:
Public.

Description

Add a confirmation dialog confirming the completion of uninstallation for Chrome Frame. BUG=http://crbug.com/23995 TEST=Uninstall Chrome Frame in such a way that a reboot is not required. Verify that a confirmation dialog appears. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30780

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M chrome/app/chromium_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/installer/setup/setup_main.cc View 1 1 chunk +14 lines, -4 lines 0 comments Download
M chrome/installer/util/prebuild/create_string_rc.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
robertshield
11 years, 1 month ago (2009-11-02 22:51:27 UTC) #1
amit
lgtm
11 years, 1 month ago (2009-11-02 23:41:23 UTC) #2
kuchhal
11 years, 1 month ago (2009-11-02 23:45:47 UTC) #3
lgtm.

Powered by Google App Engine
This is Rietveld 408576698