Issue 3549023: CommandLine: deprecate another function on non-Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3549023: CommandLine: deprecate another function on non-Windows (Closed)

Created:
10 years, 2 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, Paweł Hajdan Jr., brettw-cc_chromium.org

Visibility:
Public.

Description

CommandLine: deprecate another function on non-Windows BUG=23581 TEST=CommandLine unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61889

Patch Set 1 #

Total comments: 1

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -8 lines)			Patch
M	base/command_line.h	View	1 chunk	+1 line, -1 line	1 comment	Download
M	base/command_line.cc	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	base/command_line_unittest.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

LGTM if it builds. http://codereview.chromium.org/3549023/diff/1/3 File base/command_line.h (right): http://codereview.chromium.org/3549023/diff/1/3#newcode167 base/command_line.h:167: std::wstring program() const; Where is ...

10 years, 2 months ago (2010-10-07 00:28:38 UTC) #2

Evan Martin

10 years, 2 months ago (2010-10-07 19:50:52 UTC) #3

On 2010/10/07 00:28:38, viettrungluu wrote:
> http://codereview.chromium.org/3549023/diff/1/3#newcode167
> base/command_line.h:167: std::wstring program() const;
> Where is this used in Windows code anyway? (And maybe any such usages should
be
> converted to use GetProgram() instead?)

Yeah, next change.  ):

Expand Messages | Collapse Messages