Mac: Fix deadlock in the accelerated drawing code.

Mac: Fix deadlock in the accelerated drawing code.

Also stop the display link thread for background tabs even if --disable-hole-punching is active.

BUG=55754
TEST=Go to a page that uses the compositor (e.g. http://webkit.org/blog/386/3d-transforms/), then keep resizing the browser window for ~10 minutes. The browser should stay functional.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60984

[Nico, 2010-09-29 17:45:10]

Not the most elegant approach, but can't think of anything better right now. I
considered calling CVDisplayLinkSetCurrentCGDisplayFromOpenGLContext() before
taking the cgl lock, which would fix the problem as well, but I don't know what
happens if you call that function with a not updated context.

[Nico, 2010-09-29 18:12:36]

(mac compile failure is unrelated)

[Ken Russell (switch to Gerrit), 2010-09-29 20:22:49]

LGTM. Good work diagnosing this.

[pink (ping after 24hrs), 2010-09-29 21:08:11]

LGTM with nits. sorry for the late response (perf).

http://codereview.chromium.org/3549004/diff/2001/3001
File chrome/browser/renderer_host/render_widget_host_view_mac.mm (right):

http://codereview.chromium.org/3549004/diff/2001/3001#newcode349
chrome/browser/renderer_host/render_widget_host_view_mac.mm:349: // If hole
pushing is enabled, inform the window hosing this accelerated view
hole pushing or hole punching? hosing or hosting?

[pink (ping after 24hrs), 2010-09-29 21:08:54]

argh, rietveld ate my previous comment.

http://codereview.chromium.org/3549004/diff/2001/3001
File chrome/browser/renderer_host/render_widget_host_view_mac.mm (right):

http://codereview.chromium.org/3549004/diff/2001/3001#newcode291
chrome/browser/renderer_host/render_widget_host_view_mac.mm:291:
globalFrameDidChangeCGLLockCount_++;
can you add a comment here as to where globalFrameDidChange: is called
recurively? it's not obvious.

[Nico, 2010-09-29 21:14:02]

addressed in http://codereview.chromium.org/3576004

http://codereview.chromium.org/3549004/diff/2001/3001
File chrome/browser/renderer_host/render_widget_host_view_mac.mm (right):

http://codereview.chromium.org/3549004/diff/2001/3001#newcode349
chrome/browser/renderer_host/render_widget_host_view_mac.mm:349: // If hole
pushing is enabled, inform the window hosing this accelerated view
On 2010/09/29 21:08:11, pink wrote:
> hole pushing or hole punching? hosing or hosting?

freud strikes again