Tegra2: input: Add tegra keyboard support.

Tegra2: input: Add tegra keyboard support.

Added Tegra keyboard driver sources. The driver will be enabled in a seperate commit.

Change-Id: I1aa49341af62c0927fa3051cad274ce9d2795eaa
Signed-off-by: Rakesh Iyer <riyer@nvidia.com>;

BUG=None
TEST=Works well on seaboard.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=48d2f0b

[Rakesh Iyer, 2010-10-01 20:00:37]

Added tegra keyboard support.

[Rakesh Iyer, 2010-10-04 18:20:38]

Added chromeboy and Tom Warren as reviewers.

[robotboy, 2010-10-04 19:46:48]

So, when I apply this patch and the one to enable this for Seaboard I get a
functional keyboard (yay), and most commands seem to work fine, but when I try
"help" or "?" the console hangs after echoing the "\r\n" and gives no further
output...  I don't see anything in this patch that should be causing that
though.  Could you verify that the "help" command still works for you with this
change?

Thanks,
    Anton

[Rakesh Iyer, 2010-10-04 19:56:19]

I had seen that as well. Maybe that is because Enter actually should map to 2
keys "\r" and then "\n". Let me look into this and submit a patch.

[Tom Warren, 2010-10-04 20:20:03]

http://codereview.chromium.org/3548006/diff/1/2
File board/tegra2/seaboard/Makefile (right):

http://codereview.chromium.org/3548006/diff/1/2#newcode30
board/tegra2/seaboard/Makefile:30: #ifdef CONFIG_TEGRA_KEYBOARD
Let's use CONFIG_TEGRA2_KEYBOARD. Every other driver (GPIO, I2C, SPI, etc.) and
99% of the feature CONFIGs are using TEGRA2.

http://codereview.chromium.org/3548006/diff/1/3
File board/tegra2/seaboard/seaboard_kbc.c (right):

http://codereview.chromium.org/3548006/diff/1/3#newcode25
board/tegra2/seaboard/seaboard_kbc.c:25: 
There doesn't appear to be anything Seaboard-specific here. Can we move this up
to 'common' and call it 'init_kbc.c' or similar?

http://codereview.chromium.org/3548006/diff/1/4
File common/stdio.c (right):

http://codereview.chromium.org/3548006/diff/1/4#newcode234
common/stdio.c:234: #ifdef CONFIG_TEGRA_KEYBOARD
I don't think this is how we want to call the kbc init. See the README - you
need to provide a drv_keyboard_init in your board-specific code (i.e.
tegra-kbc.c). Note that there are no other board/chipset-specific IFDEF's in
stdio.c.

http://codereview.chromium.org/3548006/diff/1/5
File drivers/input/Makefile (right):

http://codereview.chromium.org/3548006/diff/1/5#newcode29
drivers/input/Makefile:29: COBJS-$(CONFIG_TEGRA_KEYBOARD) += tegra-kbc.o
This should be CONFIG_TEGRA2_KEYBOARD. Every other driver (GPIO, I2C, SPI, etc.)
and 99% of the feature CONFIGs are using TEGRA2.

http://codereview.chromium.org/3548006/diff/1/6
File drivers/input/tegra-kbc.c (right):

http://codereview.chromium.org/3548006/diff/1/6#newcode347
drivers/input/tegra-kbc.c:347: int tegra_kbc_init(void)
Either change this to dev_keyboard_init for create a dev_keyboard_init that just
calls tegra_kbc_init (see README and stdio.c).

http://codereview.chromium.org/3548006/diff/1/7
File include/stdio_dev.h (right):

http://codereview.chromium.org/3548006/diff/1/7#newcode117
include/stdio_dev.h:117: #ifdef CONFIG_TEGRA_KEYBOARD
This can go away (see my comment in stdio.c) when you add drv_keyboard_init to
your board-specific kbc code.

[robotboy, 2010-10-04 21:54:36]

On 2010/10/04 19:56:19, Rakesh Iyer wrote:
> I had seen that as well. Maybe that is because Enter actually should map to 2
> keys "\r" and then "\n". Let me look into this and submit a patch.

I'm not sure that is the case because I was able to run other commands just
fine, it's only the "help" and "?" commands that failed for me...

Thanks,
    Anton

[Rakesh Iyer, 2010-10-04 22:26:38]

You are right Anton. That was just my guess. I figured out the problem.
Currently I am incorporating Toms suggestions as well into this patch.

[Rakesh Iyer, 2010-10-04 23:08:18]

Incorporated most of Tom Warren's comments. seaboard_kbc.c exists inside
seaboard directory because it contains pinmux, pullup and tristate settings
which are board specific. A seperate change to config files (I am creating the
issue as we speak) will be needed to test this out.

[Rakesh Iyer, 2010-10-04 23:22:16]

The issue for config file changes remains "3613002  Tegra2: Enable keyboard for
seaboard configs." .

[robotboy, 2010-10-04 23:48:31]

LGTM, thanks.

[Tom Warren, 2010-10-05 15:30:12]

http://codereview.chromium.org/3548006/diff/20001/21002
File board/tegra2/seaboard/seaboard.c (right):

http://codereview.chromium.org/3548006/diff/20001/21002#newcode230
board/tegra2/seaboard/seaboard.c:230: {
I was thinking more along the lines of your putting this into your kbd driver in
drivers/input (see board/rbc823/kbd.c, for example), but this will do, too.

[robotboy, 2010-10-06 21:09:24]

Actually, looking over the code (after noticing a compiler warning that I
hadn't seen before) I think Tom is right.  I have a simple patch to fix it
that I'll send your way shortly.

Thanks,
    Anton

On Tue, Oct 5, 2010 at 8:30 AM, <twarren.nvidia@gmail.com> wrote:

>
> http://codereview.chromium.org/3548006/diff/20001/21002
> File board/tegra2/seaboard/seaboard.c (right):
>
> http://codereview.chromium.org/3548006/diff/20001/21002#newcode230
> board/tegra2/seaboard/seaboard.c:230: {
> I was thinking more along the lines of your putting this into your kbd
> driver in drivers/input (see board/rbc823/kbd.c, for example), but this
> will do, too.
>
>
> http://codereview.chromium.org/3548006/show
>