chrome/browser/renderer_host/render_widget_host_unittest.cc - Issue 3547008: Handle resize corner layout entirely in the platform BrowserWindow*/BrowserView* code...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/render_widget_host_unittest.cc

Issue 3547008: Handle resize corner layout entirely in the platform BrowserWindow*/BrowserView* code... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 10 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/cocoa/tab_contents_controller.mm ('K') | « chrome/browser/renderer_host/render_widget_host.cc ('k') | chrome/browser/renderer_host/render_widget_host_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/renderer_host/render_widget_host_unittest.cc

===================================================================

--- chrome/browser/renderer_host/render_widget_host_unittest.cc (revision 65756)

+++ chrome/browser/renderer_host/render_widget_host_unittest.cc (working copy)

@@ -352,28 +352,33 @@

host_->WasResized();

EXPECT_FALSE(host_->resize_ack_pending_);

EXPECT_EQ(gfx::Size(), host_->in_flight_size_);

+ EXPECT_EQ(gfx::Size(), host_->current_size_);

EXPECT_TRUE(process_->sink().GetUniqueMessageMatching(ViewMsg_Resize::ID));

// Send a rect that has no area but has either width or height set.

+ // since we do not expect ACK, current_size_ should be updated right away.

process_->sink().ClearMessages();

view_->set_bounds(gfx::Rect(0, 0, 0, 30));

host_->WasResized();

EXPECT_FALSE(host_->resize_ack_pending_);

- EXPECT_EQ(gfx::Size(0, 30), host_->in_flight_size_);

+ EXPECT_EQ(gfx::Size(), host_->in_flight_size_);

+ EXPECT_EQ(gfx::Size(0, 30), host_->current_size_);

EXPECT_TRUE(process_->sink().GetUniqueMessageMatching(ViewMsg_Resize::ID));

// Set the same size again. It should not be sent again.

process_->sink().ClearMessages();

host_->WasResized();

EXPECT_FALSE(host_->resize_ack_pending_);

- EXPECT_EQ(gfx::Size(0, 30), host_->in_flight_size_);

+ EXPECT_EQ(gfx::Size(), host_->in_flight_size_);

+ EXPECT_EQ(gfx::Size(0, 30), host_->current_size_);

EXPECT_FALSE(process_->sink().GetFirstMessageMatching(ViewMsg_Resize::ID));

// A different size should be sent again, however.

view_->set_bounds(gfx::Rect(0, 0, 0, 31));

host_->WasResized();

EXPECT_FALSE(host_->resize_ack_pending_);

- EXPECT_EQ(gfx::Size(0, 31), host_->in_flight_size_);

+ EXPECT_EQ(gfx::Size(), host_->in_flight_size_);

+ EXPECT_EQ(gfx::Size(0, 31), host_->current_size_);

EXPECT_TRUE(process_->sink().GetUniqueMessageMatching(ViewMsg_Resize::ID));

}