Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 3546003: Add another check to be sure non-negative smi fits into Uint32 range. (Closed)

Created:
10 years, 2 months ago by antonm
Modified:
9 years, 4 months ago
Reviewers:
Vitaly Repeshko
CC:
v8-dev
Visibility:
Public.

Description

Add another check to be sure non-negative smi fits into Uint32 range. Committed: http://code.google.com/p/v8/source/detail?r=5558

Patch Set 1 #

Patch Set 2 : simpler #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/x64/ic-x64.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
antonm
Vitaly, may you have a look?
10 years, 2 months ago (2010-09-29 17:14:50 UTC) #1
Vitaly Repeshko
10 years, 2 months ago (2010-09-29 17:15:49 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698