Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Issue 3541011: entd: Add policy signatures (Closed)

Created:
10 years, 2 months ago by rginda
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, rginda, gauravsh
Visibility:
Public.

Description

entd: Add policy signatures This is a first pass at signed enterprise policies. A single script is provided that can sign policies and verify signatures. Another CL will use this script to start the enterprise daemon after verifying the signature. In the future the signature verification should be baked directly into entd. entdwife.sh: initial add of utility script to sign and verify policies. main.cc: check for root-cert.pem, root_cert.pem as a backup. fix_pkcs11_token.sh: add lcense header. add trailing / to 127.0.0.1 permission check. BUG=chromium-os:4621 TEST=gmerge onto device and test with signed and unsigned policies Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=7b26ac5

Patch Set 1 #

Total comments: 16

Patch Set 2 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+576 lines, -3 lines) Patch
M base_policy/policy-utils.js View 1 chunk +1 line, -1 line 0 comments Download
A bin/entdwife.sh View 1 1 chunk +564 lines, -0 lines 0 comments Download
M bin/fix_pkcs11_token.sh View 1 chunk +3 lines, -0 lines 0 comments Download
M main.cc View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rginda
http://codereview.chromium.org/3541011/diff/1/2 File base_policy/policy-utils.js (right): http://codereview.chromium.org/3541011/diff/1/2#newcode55 base_policy/policy-utils.js:55: if (perms.length != 1 || perms[0].indexOf("http://127.0.0.1/") != 0) This ...
10 years, 2 months ago (2010-10-04 18:41:13 UTC) #1
Chris Masone
http://codereview.chromium.org/3541011/diff/1/3 File bin/entdwife.sh (right): http://codereview.chromium.org/3541011/diff/1/3#newcode28 bin/entdwife.sh:28: "Verify the authenticity of the signature" "C" Why not ...
10 years, 2 months ago (2010-10-04 20:39:48 UTC) #2
rginda
PTAL http://codereview.chromium.org/3541011/diff/1/3 File bin/entdwife.sh (right): http://codereview.chromium.org/3541011/diff/1/3#newcode28 bin/entdwife.sh:28: "Verify the authenticity of the signature" "C" On ...
10 years, 2 months ago (2010-10-04 20:56:04 UTC) #3
Chris Masone
10 years, 2 months ago (2010-10-04 22:19:15 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698