Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 354027: Implement typeof in fast compiler. (Closed)

Created:
11 years, 1 month ago by William Hesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Implement typeof in fast compiler. Committed: http://code.google.com/p/v8/source/detail?r=3222

Patch Set 1 #

Total comments: 8

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 8

Patch Set 4 : '' #

Total comments: 4

Patch Set 5 : '' #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -7 lines) Patch
M src/arm/fast-codegen-arm.cc View 4 4 chunks +36 lines, -3 lines 1 comment Download
M src/compiler.cc View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/fast-codegen-ia32.cc View 4 3 chunks +34 lines, -2 lines 0 comments Download
M src/x64/fast-codegen-x64.cc View 1 2 3 4 3 chunks +34 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
William Hesse
Only on x64 platform right now. What about when we are inside a function?
11 years, 1 month ago (2009-11-03 16:04:48 UTC) #1
Kevin Millikin (Chromium)
I could be wrong, but I thought this should be simpler (and more complicated in ...
11 years, 1 month ago (2009-11-03 16:48:09 UTC) #2
William Hesse
Comments addressed, new version uploaded. http://codereview.chromium.org/354027/diff/1/3 File src/x64/fast-codegen-x64.cc (right): http://codereview.chromium.org/354027/diff/1/3#newcode1014 Line 1014: Comment cmnt(masm_, "[ ...
11 years, 1 month ago (2009-11-04 14:30:08 UTC) #3
William Hesse
Finished. All platforms tested. Lookup Slots are not used in the fast compiler yet, but ...
11 years, 1 month ago (2009-11-04 15:25:27 UTC) #4
Kevin Millikin (Chromium)
http://codereview.chromium.org/354027/diff/7001/8002 File src/x64/fast-codegen-x64.cc (right): http://codereview.chromium.org/354027/diff/7001/8002#newcode1100 Line 1100: Comment cmnt(masm_, "[ UnaryOperation (TYPEOF)"); Might put an ...
11 years, 1 month ago (2009-11-04 16:51:17 UTC) #5
Kevin Millikin (Chromium)
http://codereview.chromium.org/354027/diff/7003/7007 File src/arm/fast-codegen-arm.cc (right): http://codereview.chromium.org/354027/diff/7003/7007#newcode1024 Line 1024: __ push(r0); Because the context is (conveniently) the ...
11 years, 1 month ago (2009-11-04 17:54:28 UTC) #6
William Hesse
All comments addressed. http://codereview.chromium.org/354027/diff/7001/8002 File src/x64/fast-codegen-x64.cc (right): http://codereview.chromium.org/354027/diff/7001/8002#newcode1100 Line 1100: Comment cmnt(masm_, "[ UnaryOperation (TYPEOF)"); ...
11 years, 1 month ago (2009-11-05 09:49:09 UTC) #7
Kevin Millikin (Chromium)
11 years, 1 month ago (2009-11-05 10:10:26 UTC) #8
LGTM.

http://codereview.chromium.org/354027/diff/11001/11005
File src/arm/fast-codegen-arm.cc (right):

http://codereview.chromium.org/354027/diff/11001/11005#newcode1022
Line 1022: // Use a regular load, not a contextual load, to avoid reference
error.
error => errors :)

Powered by Google App Engine
This is Rietveld 408576698