Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 354018: Convert tabcontentscontainer to use a vbox instead of a fixed. The (Closed)

Created:
11 years, 1 month ago by tony
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Convert tabcontentscontainer to use a vbox instead of a fixed. The comment in the code mentions that a vbox would cause a split screen, but looking at the code, it seems like that's not possible because we hide the old TCVG before adding new ones. These days the vbox contains all TCVGs and only shows one at a time (I think in the past we tried to remove them, but we don't have that problem now). This simplifies the code by not having to use our own size-allocate handler. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30843

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -53 lines) Patch
M chrome/browser/gtk/tab_contents_container_gtk.h View 2 chunks +3 lines, -14 lines 0 comments Download
M chrome/browser/gtk/tab_contents_container_gtk.cc View 7 chunks +8 lines, -37 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents_view_gtk.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tony
11 years, 1 month ago (2009-11-03 02:19:29 UTC) #1
Evan Stade
lg if it works to refresh my memory, the TCVG still uses a fixed for ...
11 years, 1 month ago (2009-11-03 02:26:11 UTC) #2
tony
11 years, 1 month ago (2009-11-03 18:49:01 UTC) #3
On 2009/11/03 02:26:11, Evan Stade wrote:
> lg if it works
> 
> to refresh my memory, the TCVG still uses a fixed for its highest level
widget,
> right? In my recollection the problem with showing more than one tab contents
> was in TCVG where it would show an interstitial and a normal page at the same
> time.

It seems that way based on the second to last review comment here:
http://codereview.chromium.org/113590

This patch seems to work fine with interstitial pages and with dragging tabs
around (the other case where we add/remove TCVGs).

Powered by Google App Engine
This is Rietveld 408576698