Issue 354010: Handle GTK enter and leave notification events and pass them to WebKit as ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 354010: Handle GTK enter and leave notification events and pass them to WebKit as ... (Closed)

Created:
11 years, 1 month ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), ben+cc_chromium.org, jam, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Handle GTK enter and leave notification events and pass them to WebKit as mouse move events. This prevents an HTML widget from staying in the mouseover state when the cursor leaves the window. Add a new ui test that checks the specific case that was broken by warping the mouse pointer inside and outside the content area. BUG=24660 TEST=ui_tests patch by Dominic Mazzoni <dmazzoni [at] google> original review: http://codereview.chromium.org/274010/show Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30726

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+225 lines, -1 line)			Patch
M	chrome/browser/automation/automation_provider.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/automation/automation_provider.cc	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_gtk.cc	View	3 chunks	+17 lines, -1 line	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/automation/automation_messages_internal.h	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/test/automation/window_proxy.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/test/automation/window_proxy.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
A	chrome/test/data/mouseleave.html	View	1 chunk	+42 lines, -0 lines	0 comments	Download
A	chrome/test/ui/mouseleave_uitest.cc	View	1 chunk	+99 lines, -0 lines	0 comments	Download
M	webkit/api/public/gtk/WebInputEventFactory.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	webkit/api/src/gtk/WebInputEventFactory.cpp	View	1 chunk	+36 lines, -0 lines	0 comments	Download