Issue 354005: Do not touch a NPStream object when it is already destructed....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 354005: Do not touch a NPStream object when it is already destructed.... (Closed)

Created:
11 years, 1 month ago by Yusuke Sato

Modified:
9 years, 7 months ago

Reviewers:
jam, Evan Martin

CC:
chromium-reviews_googlegroups.com, darin (slow to review), jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Do not touch a NPStream object when it is already destructed. BUG=20651 TEST=Run "sh tools/valgrind/valgrind_webkit_tests.sh --debug LayoutTests/plugins/destroy-stream-twice.html" and verify that the "Invalid read of size 4" error at NPP_DestroyStream() is not reported in the log (vlayout-NNNNN.log). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30769

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	webkit/glue/plugins/plugin_instance.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yusuke Sato

Evan, Can I ask you to review this change? I've confirmed that this change fixes ...

11 years, 1 month ago (2009-11-02 15:25:46 UTC) #1

LGTM, +jam FYI

Expand Messages | Collapse Messages