Cleanup of the parser.

Cleanup of the parser.

The lazy parsing functions took a host of arguments that can all be
derived from the SharedFunctionInfo, and the SharedFunctionInfo is
always available when parsing lazily.  Change the interface to take a
single CompilationInfo or SharedFunctionInfo argument.

Also remove a flag in the parser that was always false when it was read.

Committed: http://code.google.com/p/v8/source/detail?r=5561

[Lasse Reichstein, 2010-09-30 09:11:41]

LGTM

http://codereview.chromium.org/3538005/diff/1/2
File src/compiler.cc (right):

http://codereview.chromium.org/3538005/diff/1/2#newcode409
src/compiler.cc:409: Handle<String>(String::cast(shared->name())),
Not your code, but how do we know that shared->name() isn't undefined?
Could there be another function to call than shared->name() for the case where
the result might be a non-string, so that ->name() always returns a String?

http://codereview.chromium.org/3538005/diff/1/4
File src/parser.h (left):

http://codereview.chromium.org/3538005/diff/1/4#oldcode196
src/parser.h:196: // source of the script where the function is declared. The
start_position and
Thank you for removing this sentence. :)

[Kevin Millikin (Chromium), 2010-09-30 09:39:48]

http://codereview.chromium.org/3538005/diff/1/2
File src/compiler.cc (right):

http://codereview.chromium.org/3538005/diff/1/2#newcode409
src/compiler.cc:409: Handle<String>(String::cast(shared->name())),
On 2010/09/30 09:11:41, Lasse Reichstein wrote:
> Not your code, but how do we know that shared->name() isn't undefined?
> Could there be another function to call than shared->name() for the case where
> the result might be a non-string, so that ->name() always returns a String?

I actually think name should *be* a string so that name() always returns a
string.

JS is untyped, but there's no reason that our internal data structures
(SharedFunctionInfo, FunctionTemplateInfo, etc) should be.

As far as I know, name is either a non-empty string or undefined.  That seems
like too much cuteness.  It ought to work to represent the absence of a name by
an empty string.