Fixes for cbuild to work with ctest.

Fixes for cbuild to work with ctest.

1)  image_to_vm aborts because e2fschk requires a terminal to 
be connected in order to check whether or not you want to repair the fs.  Since
we always want this to be true, set -p

2)  Clean up test harness to only verify the number of tests that passed on the
base image are the same on the update back to.  This is because older images
have many tests that fail.  I leave 10% as a reasonable number to pass.

3)  Redirect output from autotest in run_remote_tests to stderr so it gets
logged in a calling script that captures stdout.

Change-Id: If412274353683add20d136747113eb9c2bd41330

BUG=4690, 5533, 7287
TEST=Ran with internal tools for builders.

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=020aa69

[sosa, 2010-10-08 05:48:58]

petkov - for core of review

kmixter - run_remote_tests.sh -- not a big change as I don't think you have
anything relying on /dev/stdout from run_remote_tests.sh.  This is absolutely
necessary but makes output much nicer from a script that absorbs stdout (i.e you
still get the stderr from autotest while the tests are running in whatever
you're logging to).

[petkov, 2010-10-08 06:31:58]

http://codereview.chromium.org/3536018/diff/8001/9001
File bin/cros_au_test_harness.py (right):

http://codereview.chromium.org/3536018/diff/8001/9001#newcode14
bin/cros_au_test_harness.py:14: from cros_build_lib import
ReinterpretPathForChroot
sort these?

http://codereview.chromium.org/3536018/diff/8001/9001#newcode49
bin/cros_au_test_harness.py:49: def ParseGenerateTestReportOutput(self, output):
I'd rename this to something shorter (e.g., ParseReportOutput).

http://codereview.chromium.org/3536018/diff/8001/9001#newcode83
bin/cros_au_test_harness.py:83: Verifies that the test images passes the percent
required.
typo: image?

http://codereview.chromium.org/3536018/diff/8001/9001#newcode87
bin/cros_au_test_harness.py:87: the non-decimal percentage i.e. 0-100.
non-decimal? I think remove the whole sentence (and maybe just put 0-100 in
parenthesis).

http://codereview.chromium.org/3536018/diff/8001/9001#newcode158
bin/cros_au_test_harness.py:158: def VerifyImage(self, percent):
shouldn't this be percent_required_to_pass?

http://codereview.chromium.org/3536018/diff/8001/9001#newcode169
bin/cros_au_test_harness.py:169:
self.assertTrue(self.ParseGenerateTestReportOutput(output) >=
the doc string says you're returning the tests that passed rather than
asserting?

http://codereview.chromium.org/3536018/diff/8001/9001#newcode243
bin/cros_au_test_harness.py:243:
self.assertTrue(self.ParseGenerateTestReportOutput(output) >=
assert or return?

[sosa, 2010-10-08 22:28:29]

PTAL.  

I've fixed all the bugs I introduced in the last patch.  I also passed
--no_graphics and --type and --remote to ctest so that one could use ctest
easily to do run all the same tests on real hardware.  Testing this now.

[petkov, 2010-10-08 23:01:03]

LGTM w/ a couple of suggestions

http://codereview.chromium.org/3536018/diff/12001/13001
File bin/cros_au_test_harness.py (right):

http://codereview.chromium.org/3536018/diff/12001/13001#newcode60
bin/cros_au_test_harness.py:60: Info('Percent of tests passed %s' %
str(percent_passed))
do you really need str() here?

http://codereview.chromium.org/3536018/diff/12001/13001#newcode111
bin/cros_au_test_harness.py:111: print output
is this a debug leftover?

http://codereview.chromium.org/3536018/diff/12001/13001#newcode128
bin/cros_au_test_harness.py:128: percent_passed = self.VerifyImage(10)
bump this up and add a TODO for the right fix as discussed

http://codereview.chromium.org/3536018/diff/12001/13001#newcode151
bin/cros_au_test_harness.py:151: percent_passed = self.VerifyImage(10)
increase and a TODO

[sosa, 2010-10-08 23:36:06]

Thanks for reviewing.  Pushing.

http://codereview.chromium.org/3536018/diff/12001/13001
File bin/cros_au_test_harness.py (right):

http://codereview.chromium.org/3536018/diff/12001/13001#newcode60
bin/cros_au_test_harness.py:60: Info('Percent of tests passed %s' %
str(percent_passed))
On 2010/10/08 23:01:04, petkov wrote:
> do you really need str() here?
> 

Done.

http://codereview.chromium.org/3536018/diff/12001/13001#newcode111
bin/cros_au_test_harness.py:111: print output
On 2010/10/08 23:01:04, petkov wrote:
> is this a debug leftover?
> 
No ... see the Info msg above.

http://codereview.chromium.org/3536018/diff/12001/13001#newcode128
bin/cros_au_test_harness.py:128: percent_passed = self.VerifyImage(10)
On 2010/10/08 23:01:04, petkov wrote:
> bump this up and add a TODO for the right fix as discussed
> 

Done.

http://codereview.chromium.org/3536018/diff/12001/13001#newcode151
bin/cros_au_test_harness.py:151: percent_passed = self.VerifyImage(10)
On 2010/10/08 23:01:04, petkov wrote:
> increase and a TODO
> 

Done.