Issue 3533003: Fix devserver with handling custom labels.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3533003: Fix devserver with handling custom labels. (Closed)

Created:
10 years, 2 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
petkov

CC:
chromium-os-reviews_chromium.org, Nick Sanders

Base URL:
http://git.chromium.org/git/dev-util.git

Visibility:
Public.

Description

Fix devserver with handling custom labels and add preference to always use cached image. Change-Id: I701cba5bb9ad91a2574e8b309e8fafda528d7bc5 BUG=7152 5924 TEST=Tested with archive_dir and label set using example from dale. Also tested with factory options that are archive_build with dir and updater using default options. Url's are correct in both places Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=5d342a2

Patch Set 1 #

Patch Set 2 : Fix devserver #

Patch Set 3 : Add debug #

Total comments: 1

Patch Set 4 : petkov #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -22 lines)			Patch
	M	autoupdate.py	View	1 2	5 chunks	+37 lines, -21 lines	0 comments	Download
	M	devserver.py	View	2 3	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

10 years, 2 months ago (2010-09-28 23:45:32 UTC) #2

LGTM

http://codereview.chromium.org/3533003/diff/5001/4
File devserver.py (right):

http://codereview.chromium.org/3533003/diff/5001/4#newcode97
devserver.py:97: help='Prefer cached over image regardless of timestamps.')
"Prefer cached image..."?

Expand Messages | Collapse Messages