Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Issue 3533001: Add SetMinimumWidth to Menu2 for chromeos. Removed LanguageSwitchModel::GetFirstLevelMenuWidth (Closed)

Created:
10 years, 2 months ago by oshima
Modified:
9 years, 6 months ago
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Add SetMinimumWidth to Menu2 for chromeos. This is to remove gtk dependency from menu2 code in chromeos and to make DOMUI transition smooth (crosbug.com/6497) Removed LanguageSwitchModel::GetFirstLevelMenuWidth as this does not seem to be used by anyone. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=60961

Patch Set 1 #

Patch Set 2 : " #

Total comments: 2

Patch Set 3 : updated comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -13 lines) Patch
M chrome/browser/chromeos/login/language_switch_menu.h View 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/login/language_switch_menu.cc View 1 1 chunk +1 line, -10 lines 0 comments Download
M chrome/browser/chromeos/status/network_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/controls/menu/menu_2.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M views/controls/menu/menu_2.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M views/controls/menu/menu_wrapper.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M views/controls/menu/native_menu_gtk.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M views/controls/menu/native_menu_gtk.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M views/controls/menu/native_menu_win.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M views/controls/menu/native_menu_win.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
oshima
Ben this the version w/o ifdef macros. Denis, is it okay to remove LanguageSwitchModel::GetFirstLevelMenuWidth()? Looks ...
10 years, 2 months ago (2010-09-28 23:47:05 UTC) #1
Ben Goodger (Google)
views bits LGTM.
10 years, 2 months ago (2010-09-29 00:10:14 UTC) #2
glotov
LGTM http://codereview.chromium.org/3533001/diff/7001/8002 File chrome/browser/chromeos/login/language_switch_menu.h (right): http://codereview.chromium.org/3533001/diff/7001/8002#newcode36 chrome/browser/chromeos/login/language_switch_menu.h:36: // Returns original width of the first level ...
10 years, 2 months ago (2010-09-29 13:20:36 UTC) #3
oshima
10 years, 2 months ago (2010-09-29 17:34:45 UTC) #4
http://codereview.chromium.org/3533001/diff/7001/8002
File chrome/browser/chromeos/login/language_switch_menu.h (right):

http://codereview.chromium.org/3533001/diff/7001/8002#newcode36
chrome/browser/chromeos/login/language_switch_menu.h:36: // Returns original
width of the first level menu to be shown when called.
On 2010/09/29 13:20:36, glotov wrote:
> Returns -> Sets

updated the comment.

Powered by Google App Engine
This is Rietveld 408576698