Add a pref checkbox to enable/disable screen lock for ChromeOs.

Add a pref checkbox to enable/disable screen lock for ChromeOs.

- Add an "Account" section to personal options page that has an account
  picture and a checkbox to enable/disable screen lock;
- Add CrosPersonalOptionsHandler to serve the section;
- Add a kEnableScreenLock prefs;
- Add a EnableScreenLock method to PowerLibrary to update power manager config;

BUG=chromium-os:6546
TEST=This is chrome part change for chromium-os:6546. Verify that account picture shows up correctly and /var/lib/power_manager/lock_on_idle_suspend is updated correctly based on the prefs checkbox after login.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61689

[zel, 2010-10-05 00:43:59]

http://codereview.chromium.org/3532010/diff/1/3
File chrome/browser/chromeos/cros/power_library.cc (right):

http://codereview.chromium.org/3532010/diff/1/3#newcode16
chrome/browser/chromeos/cros/power_library.cc:16:
"/var/lib/power_manager/lock_on_idle_suspend";
We should move this logic to libcros.so. I don't want to have OS-specific tricks
like this one on Chrome side.

PowerLibrary is a good place to expose this in Chrome.

http://codereview.chromium.org/3532010/diff/1/5
File chrome/browser/chromeos/dom_ui/cros_personal_options_handler.cc (right):

http://codereview.chromium.org/3532010/diff/1/5#newcode41
chrome/browser/chromeos/dom_ui/cros_personal_options_handler.cc:41: StringValue
data_url(dom_ui_util::GetImageDataUrl(account_picture));
is this going through file: schema or do we have a special datasource for this?

[xiyuan, 2010-10-05 16:46:32]

http://codereview.chromium.org/3532010/diff/1/3
File chrome/browser/chromeos/cros/power_library.cc (right):

http://codereview.chromium.org/3532010/diff/1/3#newcode16
chrome/browser/chromeos/cros/power_library.cc:16:
"/var/lib/power_manager/lock_on_idle_suspend";
On 2010/10/05 00:43:59, zel wrote:
> We should move this logic to libcros.so. I don't want to have OS-specific
tricks
> like this one on Chrome side.
> 
> PowerLibrary is a good place to expose this in Chrome.

will do.

http://codereview.chromium.org/3532010/diff/1/5
File chrome/browser/chromeos/dom_ui/cros_personal_options_handler.cc (right):

http://codereview.chromium.org/3532010/diff/1/5#newcode41
chrome/browser/chromeos/dom_ui/cros_personal_options_handler.cc:41: StringValue
data_url(dom_ui_util::GetImageDataUrl(account_picture));
On 2010/10/05 00:43:59, zel wrote:
> is this going through file: schema or do we have a special datasource for
this?

dom_ui_util::GetImageDataUrl converts a SkBitmap into a data url. The reason I
am doing this is because UserManager does not expose where the image file is and
it probably should not do that either.

[xiyuan, 2010-10-05 20:00:15]

CL updated
- Call EnableScreenLock in libcros;
- Changed account picture from 57x70 to 70x70 per new mock;

[zel, 2010-10-05 20:04:46]

LGTM