Issue 3531005: Fix HeapSnapshotsDiff test, diff implementation, and a bug introduced

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3531005: Fix HeapSnapshotsDiff test, diff implementation, and a bug introduced (Closed)

Created:
10 years, 2 months ago by mnaganov (inactive)

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

Fix HeapSnapshotsDiff test, diff implementation, and a bug introduced during snapshot size optimization. Sorry, now I figured out that the diff implementation itself was also incorrect. Reachable nodes must be filtered from the beginning, otherwise, an object that is already disconnected, but not discarded yet, will not appear as a deleted (thankfully, this bug for some reason had appeared on the x64 port.) BUG=868 TEST=HeapSnapshotRootPreservedAfterSorting Committed: http://code.google.com/p/v8/source/detail?r=5570

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -37 lines)			Patch
M	src/profile-generator.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/profile-generator.cc	View	6 chunks	+21 lines, -28 lines	0 comments	Download
M	test/cctest/cctest.status	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View	4 chunks	+16 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages