linux: fix and build test plugins on 64-bit builds

linux: fix and build test plugins on 64-bit builds

We set -fPIC just on the layout test plugins and only in 64-bit mode.
This fixes 44 plugin layout tests on 64-bit.

(Retry, now just npapi_layout_test_plugin and not npapi_test_plugin.)

BUG=18337, 24271
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30851

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30864

[Evan Martin, 2009-11-03 18:28:00]

piman: reviewer
jam/amanda: fyi

[Evan Martin, 2009-11-03 18:29:09]

http://codereview.chromium.org/353022/diff/1/3
File webkit/tools/test_shell/test_shell.gyp (right):

http://codereview.chromium.org/353022/diff/1/3#newcode531
Line 531: 'cflags': ['-fPIC']
this is the code change, the rest is just changing the indent

http://codereview.chromium.org/353022/diff/1/3#newcode624
Line 624: 'cflags': ['-fPIC']
other code change here

[piman, 2009-11-03 18:50:33]

LGTM. Thanks !

http://codereview.chromium.org/353022/diff/1/2
File webkit/tools/npapi_layout_test_plugin/PluginObject.cpp (right):

http://codereview.chromium.org/353022/diff/1/2#newcode510
Line 510:
INT32_TO_NPVARIANT(static_cast<int32>(reinterpret_cast<intptr_t>(identifier)),
*result);
80 chars

[Evan Martin, 2009-11-03 20:01:54]

http://codereview.chromium.org/353022/diff/1/2
File webkit/tools/npapi_layout_test_plugin/PluginObject.cpp (right):

http://codereview.chromium.org/353022/diff/1/2#newcode510
Line 510:
INT32_TO_NPVARIANT(static_cast<int32>(reinterpret_cast<intptr_t>(identifier)),
*result);
On 2009/11/03 18:50:33, piman wrote:
> 80 chars

This code is "Apple-style", which uses 4-space tabs and a soft column limit
around 120

[Evan Martin, 2009-11-03 21:08:34]

Retry that only does npapi_layout_test_plugin, not npapi_test_plugin which
depends on base etc.  :(