Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 353017: Change build to only have one place to list... (Closed)

Created:
11 years, 1 month ago by gman
Modified:
9 years, 7 months ago
Reviewers:
Greg Spencer
CC:
o3d-review_googlegroups.com
Visibility:
Public.

Description

Change build to only have one place to list o3djs files and build / selenium to use compiled o3djs libs. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30838

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -378 lines) Patch
M documentation/build_docs.py View 3 chunks +5 lines, -64 lines 0 comments Download
M documentation/documentation.gyp View 1 chunk +8 lines, -0 lines 0 comments Download
M documentation/get_docs_files.py View 1 chunk +4 lines, -66 lines 0 comments Download
M plugin/idl_list.manifest View 2 chunks +2 lines, -3 lines 0 comments Download
M samples/MANIFEST View 1 chunk +211 lines, -239 lines 0 comments Download
M samples/o3djs/js_list.manifest View 2 chunks +1 line, -4 lines 0 comments Download
M samples/samples_gen.py View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
gman
11 years, 1 month ago (2009-11-03 09:04:46 UTC) #1
Greg Spencer
11 years, 1 month ago (2009-11-03 16:55:22 UTC) #2
LGTM!  Thanks Gregg.

I'll fix the gyp files today to load from these manifests so that the lists are
only in one place.

Powered by Google App Engine
This is Rietveld 408576698