Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 353014: Fix the windows search path to look in oldest applicable platform dir first... (Closed)

Created:
11 years, 1 month ago by Dirk Pranke
Modified:
9 years, 7 months ago
Reviewers:
Glenn Wilson, ojan
CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org
Visibility:
Public.

Description

Fix the windows search path to look in oldest applicable platform dir first (was looking in newest dir before). TEST=none R=ojan@chromium.org BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30912

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M webkit/tools/layout_tests/layout_package/platform_utils_win.py View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dirk Pranke
Ojan, can you please take a look at this? Thanks!
11 years, 1 month ago (2009-11-03 02:57:05 UTC) #1
ojan
LGTM Glenn, just a heads up in case test_output_formatter.py needs updating.
11 years, 1 month ago (2009-11-03 19:27:54 UTC) #2
Glenn Wilson
11 years, 1 month ago (2009-11-03 19:34:00 UTC) #3
On 2009/11/03 19:27:54, ojan wrote:
> LGTM
> 
> Glenn, just a heads up in case test_output_formatter.py needs updating.

Thanks for the heads up -- about to send you the review.

Powered by Google App Engine
This is Rietveld 408576698