Issue 353008: Fix a memory bug in the new ResizeThenCrash test....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 353008: Fix a memory bug in the new ResizeThenCrash test.... (Closed)

Created:
11 years, 1 month ago by Charlie Reis

Modified:
9 years, 7 months ago

Reviewers:
Nico

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), ben+cc_chromium.org, jam, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Fix a memory bug in the new ResizeThenCrash test. (Related to http://codereview.chromium.org/348025) BUG=25097 TEST=RenderWidgetHostTest.ResizeThenCrash Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30753

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/browser/renderer_host/render_widget_host_unittest.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Charlie Reis

Using a better approach to call RendererExited without causing the view to be deleted mid-test.

11 years, 1 month ago (2009-11-02 21:20:39 UTC) #1

Nico

11 years, 1 month ago (2009-11-02 21:33:07 UTC) #2

LG.

Maybe mention in the CL description that this belongs to
http://codereview.chromium.org/348025 .