Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 353002: Fix "line 2: BUILT_PRODUCTS_DIR: command not found" (Closed)

Created:
11 years, 1 month ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
tony, Nico
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix "line 2: BUILT_PRODUCTS_DIR: command not found". <(PRODUCT_DIR) expands to an Xcode variable, $(BUILT_PRODUCTS_DIR), which is not a shell variable. The shell tries to treat it as a command expansion. Use ${BUILT_PRODUCTS_DIR} directly. BUG=none TEST=Nico Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30686

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/chrome.gyp View 1 chunk +6 lines, -4 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Mark Mentovai
TBR
11 years, 1 month ago (2009-11-02 05:48:45 UTC) #1
Nico
LG, thanks for the quick fix. http://codereview.chromium.org/353002/diff/1/2 File chrome/chrome.gyp (right): http://codereview.chromium.org/353002/diff/1/2#newcode3745 Line 3745: '<(mac_product_name) Framework.framework/Resources/theme.pak' ...
11 years, 1 month ago (2009-11-02 17:23:51 UTC) #2
tony
11 years, 1 month ago (2009-11-02 17:39:50 UTC) #3
Thanks mark, LGTM.

Powered by Google App Engine
This is Rietveld 408576698