Issue 3530007: Pass --board to get_latest_image.sh.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3530007: Pass --board to get_latest_image.sh. (Closed)

Created:
10 years, 2 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
rtc

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git

Visibility:
Public.

Description

Pass --board to get_latest_image.sh. Change-Id: Iaa388bc6dd3ef8b07199ee42de6693cad2f4368f BUG= TEST=rm src/scripts/default_board and ran image_to_vm --board x86-generic. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=bd61304

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	image_to_vm.sh	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rtc

10 years, 2 months ago (2010-10-04 20:03:13 UTC) #2

LGTM, thanks for fixing!

On Mon, Oct 4, 2010 at 1:00 PM, <sosa@chromium.org> wrote:

> Reviewers: rtc,
>
> Description:
> Pass --board to get_latest_image.sh.
>
> Change-Id: Iaa388bc6dd3ef8b07199ee42de6693cad2f4368f
>
> BUG=
> TEST=rm src/scripts/default_board and ran image_to_vm --board x86-generic.
>
> Please review this at http://codereview.chromium.org/3530007/show
>
> SVN Base: http://git.chromium.org/git/crosutils.git
>
> Affected files:
>  M image_to_vm.sh
>
>
> Index: image_to_vm.sh
> diff --git a/image_to_vm.sh b/image_to_vm.sh
> index
>
c2fb82b748584623564cff685fd1899ee15d16b5..f0c6e654fa23a945800617ef0b95f19b38da343b
> 100755
> --- a/image_to_vm.sh
> +++ b/image_to_vm.sh
> @@ -74,7 +74,7 @@ fi
>  IMAGES_DIR="${DEFAULT_BUILD_ROOT}/images/${FLAGS_board}"
>  # Default to the most recent image
>  if [ -z "${FLAGS_from}" ] ; then
> -  FLAGS_from="$(./get_latest_image.sh)"
> +  FLAGS_from="$(./get_latest_image.sh --board=${FLAGS_board})"
>  else
>   pushd "${FLAGS_from}" && FLAGS_from=`pwd` && popd
>  fi
>
>
>

Expand Messages | Collapse Messages