Issue 3529021: Mount /home as exec in mod_for_test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3529021: Mount /home as exec in mod_for_test (Closed)

Created:
10 years, 2 months ago by fes

Modified:
9 years, 7 months ago

Reviewers:
Will Drewry

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git

Visibility:
Public.

Description

This uncomments a remount line in chromeos_startup that mounts /home as exec, allowing autotest to run. Change-Id: I51df060627770d88c219501bc628e91229ac0d42 BUG=7286 TEST=Boot in mod_for_test, home is mounted exec Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=3a8f8ed

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove extra IO by having mod_for_test uncomment the remount. #

Total comments: 1

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	A	mod_for_test_scripts/900mountHomeExec	View		1 chunk	+9 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Will Drewry

http://codereview.chromium.org/3529021/diff/1/2 File mod_for_test_scripts/900setFileMarker (right): http://codereview.chromium.org/3529021/diff/1/2#newcode9 mod_for_test_scripts/900setFileMarker:9: touch "${ROOT_FS_DIR}/root/.mod_for_test" See change 3634001 for my thoughts here ...

10 years, 2 months ago (2010-10-08 01:26:15 UTC) #2

fes

Done, PTAL http://codereview.chromium.org/3529021/diff/1/2 File mod_for_test_scripts/900setFileMarker (right): http://codereview.chromium.org/3529021/diff/1/2#newcode9 mod_for_test_scripts/900setFileMarker:9: touch "${ROOT_FS_DIR}/root/.mod_for_test" On 2010/10/08 01:26:15, Will Drewry ...

10 years, 2 months ago (2010-10-08 17:45:07 UTC) #3

Will Drewry

10 years, 2 months ago (2010-10-08 18:40:06 UTC) #4

lgtm

http://codereview.chromium.org/3529021/diff/5001/6001
File mod_for_test_scripts/900mountHomeExec (right):

http://codereview.chromium.org/3529021/diff/5001/6001#newcode9
mod_for_test_scripts/900mountHomeExec:9: sed -i -e 's/#mod_for_test#//g'
${ROOT_FS_DIR}/sbin/chromeos_startup
fine as is but you can trim the trailing space too, but that's purely visual:
's/#mod_for_test# //g'

Expand Messages | Collapse Messages