Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: webkit/appcache/appcache_request_handler_unittest.cc

Issue 3529009: Fix http/tests/appcache/foreign-fallback.html (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/appcache/appcache_request_handler_unittest.cc
===================================================================
--- webkit/appcache/appcache_request_handler_unittest.cc (revision 64524)
+++ webkit/appcache/appcache_request_handler_unittest.cc (working copy)
@@ -237,7 +237,8 @@
EXPECT_TRUE(handler_.get());
mock_storage()->SimulateFindMainResource(
- AppCacheEntry(AppCacheEntry::EXPLICIT, 1), AppCacheEntry(),
+ AppCacheEntry(AppCacheEntry::EXPLICIT, 1),
+ GURL(), AppCacheEntry(),
1, GURL("http://blah/manifest/"));
job_ = handler_->MaybeLoadResource(request_.get());
@@ -277,7 +278,9 @@
EXPECT_TRUE(handler_.get());
mock_storage()->SimulateFindMainResource(
- AppCacheEntry(), AppCacheEntry(AppCacheEntry::EXPLICIT, 1),
+ AppCacheEntry(),
+ GURL("http://blah/fallbackurl"),
+ AppCacheEntry(AppCacheEntry::EXPLICIT, 1),
1, GURL("http://blah/manifest/"));
job_ = handler_->MaybeLoadResource(request_.get());
@@ -310,6 +313,8 @@
handler_->GetExtraResponseInfo(&cache_id, &manifest_url);
EXPECT_EQ(1, cache_id);
EXPECT_EQ(GURL("http://blah/manifest/"), manifest_url);
+ EXPECT_TRUE(host_->main_resource_was_fallback_);
+ EXPECT_EQ(GURL("http://blah/fallbackurl"), host_->fallback_url_);
TestFinished();
}

Powered by Google App Engine
This is Rietveld 408576698