Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(902)

Unified Diff: webkit/appcache/appcache_request_handler.h

Issue 3529009: Fix http/tests/appcache/foreign-fallback.html (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/appcache/appcache_request_handler.h
===================================================================
--- webkit/appcache/appcache_request_handler.h (revision 64524)
+++ webkit/appcache/appcache_request_handler.h (working copy)
@@ -53,7 +53,8 @@
// Helpers to instruct a waiting job with what response to
// deliver for the request we're handling.
void DeliverAppCachedResponse(const AppCacheEntry& entry, int64 cache_id,
- const GURL& manifest_url, bool is_fallback);
+ const GURL& manifest_url, bool is_fallback,
+ const GURL& fallback_url);
kinuko 2010/11/02 07:47:23 nit: per recent addition to the coding style guide
michaeln 2010/11/02 20:25:36 I'll see if this fits... void DeliverAppCachedRes
void DeliverNetworkResponse();
void DeliverErrorResponse();
@@ -72,7 +73,7 @@
// AppCacheStorage::Delegate methods
virtual void OnMainResponseFound(
const GURL& url, const AppCacheEntry& entry,
- const AppCacheEntry& fallback_entry,
+ const GURL& fallback_url, const AppCacheEntry& fallback_entry,
int64 cache_id, const GURL& mainfest_url,
bool was_blocked_by_policy);
@@ -98,9 +99,10 @@
// Info about the type of response we found for delivery.
// These are relevant for both main and subresource requests.
+ int64 found_cache_id_;
AppCacheEntry found_entry_;
AppCacheEntry found_fallback_entry_;
- int64 found_cache_id_;
+ GURL found_fallback_url_;
GURL found_manifest_url_;
bool found_network_namespace_;

Powered by Google App Engine
This is Rietveld 408576698