Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 3529007: Add a script to put in a rootfs from one image into another. (Closed)

Created:
10 years, 2 months ago by gauravsh
Modified:
9 years, 6 months ago
Reviewers:
petkov, gauravsh-google
CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson
Visibility:
Public.

Description

Add a script to put in a rootfs from one image into another. Also add an option to prevent sign_official_build from attempting to re-sign the firmware. This is needed because we want both the SSD and RECOVERY images to have the same rootfs for delta updates to work correctly. BUG=chromium-os:7242 TEST=manually verified that rootfs gets replaced correctly (by verifying the rootfs hash). Change-Id: I2ca4f2bef938ca14301fed6a0b16c1a7dc2ba6d9 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=815193d

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M scripts/image_signing/sign_official_build.sh View 1 chunk +5 lines, -0 lines 0 comments Download
A scripts/image_signing/swap_rootfs.sh View 1 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
gauravsh
10 years, 2 months ago (2010-10-01 18:07:09 UTC) #1
petkov
LGTM w/ a couple of questions: 1. You don't need firmware resigning for recovery? 2. ...
10 years, 2 months ago (2010-10-01 19:31:05 UTC) #2
gauravsh-google
On 2010/10/01 19:31:05, petkov wrote: > LGTM w/ a couple of questions: > > 1. ...
10 years, 2 months ago (2010-10-01 19:47:03 UTC) #3
gauravsh-google
http://codereview.chromium.org/3529007/diff/1/3 File scripts/image_signing/swap_rootfs.sh (right): http://codereview.chromium.org/3529007/diff/1/3#newcode19 scripts/image_signing/swap_rootfs.sh:19: usage On 2010/10/01 19:31:05, petkov wrote: > why 4 ...
10 years, 2 months ago (2010-10-01 19:47:30 UTC) #4
petkov
10 years, 2 months ago (2010-10-01 19:48:54 UTC) #5
good -- still lgtm

Powered by Google App Engine
This is Rietveld 408576698