Issue 3529005: Fix enter_chroot.sh so that it can be run from a cwd that is not in a git repository

Issue 3529005: Fix enter_chroot.sh so that it can be run from a cwd that is not in a git repository (Closed)

Created:
10 years, 2 months ago by rochberg

Modified:
9 years, 7 months ago

Reviewers:
davidjames, rochberg_internal

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git

Visibility:
Public.

Description

Fix enter_chroot.sh so that it can be run from a cwd that is not in a git repository BUG=none TEST=run from within and without a repo Change-Id: I00eb999974656450f6af24583ca2247805b5799e Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c1a3e56

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changed to always pull revision from trunk/src/scripts #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	enter_chroot.sh	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

David James

http://codereview.chromium.org/3529005/diff/1/2 File enter_chroot.sh (right): http://codereview.chromium.org/3529005/diff/1/2#newcode275 enter_chroot.sh:275: REVISION=$(git rev-parse --short=8 HEAD || echo "unknown_revision") Could you ...

10 years, 2 months ago (2010-09-30 17:33:17 UTC) #2

rochberg_internal

10 years, 2 months ago (2010-09-30 18:22:44 UTC) #3

davidjames

10 years, 2 months ago (2010-10-02 21:54:03 UTC) #4

On 2010/09/30 18:22:44, rochberg_internal wrote:
> http://codereview.chromium.org/3529005/diff/1/2
> File enter_chroot.sh (right):
> 
> http://codereview.chromium.org/3529005/diff/1/2#newcode275
> enter_chroot.sh:275: REVISION=$(git rev-parse --short=8 HEAD || echo
> "unknown_revision")
> On 2010/09/30 17:33:17, David James wrote:
> > Could you just 'cd' to the right directory instead inside the subshell? That
> > way, everybody can get a correct revision.
> 
> Done.

Thanks. LGTM.

Expand Messages | Collapse Messages