Issue 3526020: Redirected network details to options DOM UI page....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3526020: Redirected network details to options DOM UI page.... (Closed)

Created:
10 years, 2 months ago by zel

Modified:
9 years, 6 months ago

Reviewers:
dhg, stevenjb

CC:
chromium-reviews, dhg, arv (Not doing code reviews), davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Redirected network details to options DOM UI page. BUG=chromium-os:7273 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61794

Patch Set 4 : '' #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+89 lines, -19 lines)			Patch
M	chrome/browser/chromeos/status/network_menu.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/status/network_menu.cc	View	1 2	5 chunks	+53 lines, -19 lines	0 comments	Download
M	chrome/browser/resources/options/chromeos_internet_options.js	View	1 2	1 chunk	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/options/chromeos_internet_options_page.css	View	2	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/shared/js/util.js	View	1 2	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

stevenjb

Minor nit, and my JS/CSS fu is weak, but LGTM. http://codereview.chromium.org/3526020/diff/4001/5001 File chrome/browser/chromeos/status/network_menu.cc (right): http://codereview.chromium.org/3526020/diff/4001/5001#newcode14 ...

10 years, 2 months ago (2010-10-06 23:53:50 UTC) #2

zel

http://codereview.chromium.org/3526020/diff/4001/5001 File chrome/browser/chromeos/status/network_menu.cc (right): http://codereview.chromium.org/3526020/diff/4001/5001#newcode14 chrome/browser/chromeos/status/network_menu.cc:14: #include "chrome/browser/browser_list.h" On 2010/10/06 23:53:50, Steven Bennetts wrote: > ...

10 years, 2 months ago (2010-10-07 00:59:05 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 3526020: Redirected network details to options DOM UI page.... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages