Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 3526012: AU: generate a delta payload usage report (Closed)

Created:
10 years, 2 months ago by petkov
Modified:
9 years, 7 months ago
Reviewers:
adlr
CC:
chromium-os-reviews_chromium.org, petkov, adlr
Visibility:
Public.

Description

AU: generate a delta payload usage report Currently, the report is generated as part of delta payload generation. Here's a sample of the top of the report: 1.06% 1104147 BSDIFF /opt/google/o3d/libnpo3dautoplugin.so 1.53% 1596334 REPLACE_BZ /usr/share/fonts/droid-cros/DroidSansFallback.ttf 1.92% 2004371 BSDIFF /opt/google/chrome/libpdf.so 2.22% 2317201 BSDIFF /usr/sbin/chromeos-firmwareupdate 3.01% 3138556 REPLACE_BZ <kernel-operation-0> 3.01% 3139632 REPLACE /boot/vmlinuz-2.6.32.21+drm33.7 7.48% 7801907 REPLACE_BZ <rootfs-final-operation> 15.61% 16281170 BSDIFF /opt/google/chrome/chrome 28.19% 29391876 BSDIFF /usr/libexec/ibus-engine-mozc 100.00% 104276861 <total> BUG=7266 TEST=generated a delta payload and looked at the report Change-Id: I9f32f000260469cc15fd8e0f9b55a8aa10db0cd9 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=880335c

Patch Set 1 #

Total comments: 2

Patch Set 2 : review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -3 lines) Patch
M delta_diff_generator.cc View 1 3 chunks +76 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
petkov
Take a look. I guess it could be cleaner, maybe a separate file/class, etc... Open ...
10 years, 2 months ago (2010-10-01 22:03:03 UTC) #1
adlr
LGTM http://codereview.chromium.org/3526012/diff/1/2 File delta_diff_generator.cc (right): http://codereview.chromium.org/3526012/diff/1/2#newcode476 delta_diff_generator.cc:476: DeltaObject(const string& in_name, const int in_type, const size_t ...
10 years, 2 months ago (2010-10-01 22:34:19 UTC) #2
petkov
10 years, 2 months ago (2010-10-01 22:52:01 UTC) #3
pushing...

http://codereview.chromium.org/3526012/diff/1/2
File delta_diff_generator.cc (right):

http://codereview.chromium.org/3526012/diff/1/2#newcode476
delta_diff_generator.cc:476: DeltaObject(const string& in_name, const int
in_type, const size_t in_size)
On 2010/10/01 22:34:19, adlr wrote:
> i think generally we use off_t for filesize, which is guaranteed to be 64bit. 

Done.

Powered by Google App Engine
This is Rietveld 408576698