Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 3526008: Add a check that accessors set to instance template work even if we have a custom call handler. (Closed)

Created:
10 years, 2 months ago by antonm
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add a check that accessors set to instance template work even if we have a custom call handler. Committed: http://code.google.com/p/v8/source/detail?r=5590

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing Mads' comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M test/cctest/test-api.cc View 1 4 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
antonm
Mads, may you have a look? yours, anton.
10 years, 2 months ago (2010-10-01 16:04:02 UTC) #1
Mads Ager (chromium)
LGTM http://codereview.chromium.org/3526008/diff/1/2 File test/cctest/test-api.cc (right): http://codereview.chromium.org/3526008/diff/1/2#newcode769 test/cctest/test-api.cc:769: static v8::Handle<Value> Get239(Local<String> name, const AccessorInfo&) { I ...
10 years, 2 months ago (2010-10-05 08:44:31 UTC) #2
antonm
10 years, 2 months ago (2010-10-05 12:41:49 UTC) #3
Thanks a lot for review, Mads.  Submitting.

http://codereview.chromium.org/3526008/diff/1/2
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/3526008/diff/1/2#newcode769
test/cctest/test-api.cc:769: static v8::Handle<Value> Get239(Local<String> name,
const AccessorInfo&) {
On 2010/10/05 08:44:31, Mads Ager wrote:
> I think we already have a Return239 method that you can reuse instead of
adding
> a new method here.

Done

Powered by Google App Engine
This is Rietveld 408576698