Issue 3525003: Refactor platform_CryptohomeTestAuth + add testcase

Issue 3525003: Refactor platform_CryptohomeTestAuth + add testcase (Closed)

Created:
10 years, 2 months ago by seano

Modified:
9 years, 7 months ago

Reviewers:
fes, ericli, jimhebert

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org

Base URL:
http://git.chromium.org/git/autotest.git

Visibility:
Public.

Description

Refactor platform_CryptohomeTestAuth + add testcase. Also add functionality and cleanups to site_cryptohome lib. Change-Id: I250e998ab8bcc6e35da314311a929c2b1c24c40d Fix test. Change-Id: Ie200a5bfcc1114c7528ba075ec53e5ea5e6ecf3d Initial refactoring of platform_CryptohomeTestAuth Change-Id: I819a62844b4b1d63c30f5b2fd4f497e808ea3cc9 BUG= TEST=ran manually on my dev box. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e5d8fd0

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+124 lines, -77 lines)			Patch
M	client/bin/site_cryptohome.py	View	1 2 3 4 5	2 chunks	+63 lines, -3 lines	0 comments	Download
M	client/site_tests/login_CryptohomeMounted/login_CryptohomeMounted.py	View	3	2 chunks	+14 lines, -1 line	0 comments	Download
M	client/site_tests/platform_CryptohomeTestAuth/platform_CryptohomeTestAuth.py	View	1 2	1 chunk	+47 lines, -73 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

fes

Minor change required not relating to your code (cryptohome was changed). Other than that, LGTM. ...

10 years, 2 months ago (2010-09-29 16:23:38 UTC) #3

seano

10 years, 2 months ago (2010-09-29 21:38:02 UTC) #5

Added some fixes which broke due to Monday's build, and tested both tests
against a recent buildbot image.

http://codereview.chromium.org/3525003/diff/4001/5001
File client/bin/site_cryptohome.py (right):

http://codereview.chromium.org/3525003/diff/4001/5001#newcode39
client/bin/site_cryptohome.py:39: cmd = (CRYPTOHOME_CMD + ' --action=mount
--user=%s --password=%s' %
On 2010/09/29 16:23:38, fes wrote:
> If you want the vault to be created if it doesn't exist, add '--create' to the
> parameters (this changed just Monday).

Done.

http://codereview.chromium.org/3525003/diff/4001/5002
File
client/site_tests/platform_CryptohomeTestAuth/platform_CryptohomeTestAuth.py
(right):

http://codereview.chromium.org/3525003/diff/4001/5002#newcode65
client/site_tests/platform_CryptohomeTestAuth/platform_CryptohomeTestAuth.py:65:
site_cryptohome.remove_vault(test_user)
On 2010/09/29 16:23:38, fes wrote:
> This will, as you point out, fail as you cannot remove a vault while mounted. 
> Please file a bug against cryptohome to have it automatically unmount first.

Done http://code.google.com/p/chromium-os/issues/detail?id=7191

Expand Messages | Collapse Messages