Issue 3522011: Add protobuf dependency to cryptohome

Issue 3522011: Add protobuf dependency to cryptohome (Closed)

Created:
10 years, 2 months ago by fes

Modified:
9 years, 7 months ago

Reviewers:
Chris Masone

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, tedbo, adlr, anush

Base URL:
http://git.chromium.org/git/chromiumos-overlay.git

Visibility:
Public.

Description

Add protobuf dependency to cryptohome Change-Id: I3361d106aa65048df157aabc546b573543a01f11 BUG=None TEST=Compile cryptohome Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=ce838f4

Patch Set 1 #

Patch Set 2 : Address feedback. #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chromeos-base/chromeos-cryptohome/chromeos-cryptohome-9999.ebuild	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Chris Masone

you should only modify the -9999 ebuild. Then, LGTM On Mon, Oct 4, 2010 at ...

10 years, 2 months ago (2010-10-04 17:04:11 UTC) #2

you should only  modify the -9999 ebuild.  Then, LGTM

On Mon, Oct 4, 2010 at 10:01 AM, <fes@chromium.org> wrote:

> Reviewers: Chris Masone,
>
> Description:
> Add protobuf dependency to cryptohome
>
> Change-Id: I3361d106aa65048df157aabc546b573543a01f11
>
> BUG=None
> TEST=Compile cryptohome
>
> Please review this at http://codereview.chromium.org/3522011/show
>
> SVN Base: http://git.chromium.org/git/chromiumos-overlay.git
>
> Affected files:
>  M chromeos-base/chromeos-cryptohome/chromeos-cryptohome-0.0.1-r34.ebuild
>  M chromeos-base/chromeos-cryptohome/chromeos-cryptohome-9999.ebuild
>
>
> Index:
> chromeos-base/chromeos-cryptohome/chromeos-cryptohome-0.0.1-r34.ebuild
> diff --git
> a/chromeos-base/chromeos-cryptohome/chromeos-cryptohome-0.0.1-r34.ebuild
> b/chromeos-base/chromeos-cryptohome/chromeos-cryptohome-0.0.1-r34.ebuild
> index
>
6081edd6dfb2c6ae09e83435792f03465d43837c..e75a88efbf8a61a1bef4675f9e272e7c2ed7082b
> 100644
> ---
> a/chromeos-base/chromeos-cryptohome/chromeos-cryptohome-0.0.1-r34.ebuild
> +++
> b/chromeos-base/chromeos-cryptohome/chromeos-cryptohome-0.0.1-r34.ebuild
> @@ -19,6 +19,7 @@ RDEPEND="
>        dev-libs/dbus-glib
>        dev-libs/glib
>        dev-libs/openssl
> +       dev-libs/protobuf
>        sys-apps/keyutils
>        sys-fs/ecryptfs-utils"
>
> Index: chromeos-base/chromeos-cryptohome/chromeos-cryptohome-9999.ebuild
> diff --git
> a/chromeos-base/chromeos-cryptohome/chromeos-cryptohome-9999.ebuild
> b/chromeos-base/chromeos-cryptohome/chromeos-cryptohome-9999.ebuild
> index
>
d97cb7c0aa28ad40cb8b456e2486da794c0f5137..9f4f6ed28327055e1a5618571d747f796141e6d5
> 100644
> --- a/chromeos-base/chromeos-cryptohome/chromeos-cryptohome-9999.ebuild
> +++ b/chromeos-base/chromeos-cryptohome/chromeos-cryptohome-9999.ebuild
> @@ -18,6 +18,7 @@ RDEPEND="
>        dev-libs/dbus-glib
>        dev-libs/glib
>        dev-libs/openssl
> +       dev-libs/protobuf
>        sys-apps/keyutils
>        sys-fs/ecryptfs-utils"
>
>
>
>

fes

10 years, 2 months ago (2010-10-04 17:06:44 UTC) #3

On 2010/10/04 17:04:11, Chris Masone wrote:
> you should only  modify the -9999 ebuild.  Then, LGTM
> 

Taken care of--I added it to both because I've actually been using protobuf here
for a while, and the dep has been missing.  But as it will be rev'd anyway to
the 9999, it wouldn't do any good anyway.

Expand Messages | Collapse Messages