Issue 3521006: Make presubmit output less annoying for mac people.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3521006: Make presubmit output less annoying for mac people. (Closed)

Created:
10 years, 2 months ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/

Visibility:
Public.

Description

Make presubmit output less annoying for mac people. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=61277

Patch Set 1 #

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	depot_tools/presubmit_canned_checks.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

When I ran `gclient upload`, it took 31 seconds and then I got several screenful ...

10 years, 2 months ago (2010-10-01 23:55:15 UTC) #1

M-A Ruel

On 2010/10/01 23:55:15, Nico wrote: > When I ran `gclient upload`, it took 31 seconds ...

10 years, 2 months ago (2010-10-02 01:04:46 UTC) #2

Nico

10 years, 2 months ago (2010-10-02 01:52:01 UTC) #3

10.6. I do have git installed, but I believe my tools checkout is svn-based.

On Fri, Oct 1, 2010 at 6:04 PM,  <maruel@chromium.org> wrote:
> On 2010/10/01 23:55:15, Nico wrote:
>>
>> When I ran `gclient upload`, it took 31 seconds and then I got several
>
> screenful
>>
>> of test errors about some local server not running. I guess that's
>> unrelated.
>
> OSX 10.5 or 10.6? Do you have git installed?
>
> In any case, lgtm.
>
> http://codereview.chromium.org/3521006/show
>

Expand Messages | Collapse Messages