Issue 352003: [mac] Remember last used prefs tab.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 352003: [mac] Remember last used prefs tab. (Closed)

Created:
11 years, 1 month ago by Nico

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Remember last used prefs tab. BUG=21440 TEST=Open prefs, select 2nd tab. close & reopen prefs window. 2nd tab should still be selected. close & reopen chrome, open prefs. 2nd tab should still be selected. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30705

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 2

Patch Set 3 : bounds checking #

Patch Set 4 : rebase tot #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -4 lines)			Patch
	M	chrome/browser/cocoa/preferences_window_controller.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
	M	chrome/browser/cocoa/preferences_window_controller.mm	View	1 2	5 chunks	+20 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

pink (ping after 24hrs)

LGTM http://codereview.chromium.org/352003/diff/1003/1005 File chrome/browser/cocoa/preferences_window_controller.mm (right): http://codereview.chromium.org/352003/diff/1003/1005#newcode216 Line 216: NSToolbarItem* firstItem = [[toolbar_ items] objectAtIndex:(int)page]; this ...

11 years, 1 month ago (2009-11-02 16:10:55 UTC) #2

Nico

11 years, 1 month ago (2009-11-02 16:43:03 UTC) #3

Thanks, submitting.

http://codereview.chromium.org/352003/diff/1003/1005
File chrome/browser/cocoa/preferences_window_controller.mm (right):

http://codereview.chromium.org/352003/diff/1003/1005#newcode216
Line 216: NSToolbarItem* firstItem = [[toolbar_ items] objectAtIndex:(int)page];
On 2009/11/02 16:10:56, pink wrote:
> this will throw horribly and die if outside the list's range. We should make
> sure that we bounds check the value we get from the prefs system.

Done.

Expand Messages | Collapse Messages